shaw/SillyTavern
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

Allow extensions to specify minimum ST client version (#4350)

Browse Source 
* allow extensions to specify minimum client version

* using existing version compare function

* Move versionCompare to utils module

---------

Co-authored-by: qvink <qvink@users.noreply.github.com>
Co-authored-by: Cohee <18619528+Cohee1207@users.noreply.github.com>
This commit is contained in:
qvink
2025-08-04 21:31:05 +00:00
committed by GitHub
parent 00121b281a
commit 5865a1a85b
3 changed files with 24 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/scripts/extensions.js
+13 -3
View File
@@ -1,10 +1,10 @@
import { DOMPurify, Popper } from '../lib.js';
import { eventSource, event_types, saveSettings, saveSettingsDebounced, getRequestHeaders, animation_duration } from '../script.js';
import { eventSource, event_types, saveSettings, saveSettingsDebounced, getRequestHeaders, animation_duration, CLIENT_VERSION } from '../script.js';
import { showLoader } from './loader.js';
import { POPUP_RESULT, POPUP_TYPE, Popup, callGenericPopup } from './popup.js';
import { renderTemplate, renderTemplateAsync } from './templates.js';
import { delay, isSubsetOf, sanitizeSelector, setValueByPath } from './utils.js';
import { delay, isSubsetOf, sanitizeSelector, setValueByPath, versionCompare } from './utils.js';
import { getContext } from './st-context.js';
import { isAdmin } from './user.js';
import { addLocaleData, getCurrentLocale, t } from './i18n.js';
@@ -387,6 +387,7 @@ async function getManifests(names) {
*/
async function activateExtensions() {
extensionLoadErrors.clear();
const clientVersion = CLIENT_VERSION.split(':')[1];
const extensions = Object.entries(manifests).sort((a, b) => sortManifestsByOrder(a[1], b[1]));
const extensionNames = extensions.map(x => x[0]);
const promises = [];
@@ -396,11 +397,17 @@ async function activateExtensions() {
const manifest = entry[1];
const extrasRequirements = manifest.requires;
const extensionDependencies = manifest.dependencies;
const minClientVersion = manifest.minimum_client_version;
const displayName = manifest.display_name || name;
if (activeExtensions.has(name)) {
continue;
}
// Client version requirement: pass if 'minimum_client_version' is undefined or null.
let meetsClientMinimumVersion = true;
if (minClientVersion !== undefined) {
meetsClientMinimumVersion = versionCompare(clientVersion, minClientVersion);
}
// Module requirements: pass if 'requires' is undefined, null, or not an array; check subset if it's an array
let meetsModuleRequirements = true;
@@ -438,7 +445,7 @@ async function activateExtensions() {
const isDisabled = extension_settings.disabledExtensions.includes(name);
if (meetsModuleRequirements && meetsExtensionDeps && !isDisabled) {
if (meetsModuleRequirements && meetsExtensionDeps && meetsClientMinimumVersion && !isDisabled) {
try {
console.debug('Activating extension', name);
const promise = addExtensionLocale(name, manifest).finally(() =>
@@ -465,6 +472,9 @@ async function activateExtensions() {
console.warn(t`Extension "${name}" did not load. Missing required extensions: "${missingDependencies.join(', ')}"`);
extensionLoadErrors.add(t`Extension "${displayName}" did not load. Missing required extensions: "${missingDependencies.join(', ')}"`);
}
} else if (!meetsClientMinimumVersion && !isDisabled) {
console.warn(t`Extension "${name}" did not load. Requires ST client version ${minClientVersion}, but current version is ${clientVersion}.`);
extensionLoadErrors.add(t`Extension "${displayName}" did not load. Requires ST client version ${minClientVersion}, but current version is ${clientVersion}.`);
}
}