shaw/SillyTavern
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

Clarified contribution guidelines for large PRs. (#5032)

Browse Source 
* Added guidelines for splitting large PRs.

* Added links, formatting and mentioned dot property access.

* Fixed and corrected:
https://github.com/SillyTavern/SillyTavern/pull/5032#discussion_r2707433279
https://github.com/SillyTavern/SillyTavern/pull/5032#discussion_r2707445447
https://github.com/SillyTavern/SillyTavern/pull/5032#discussion_r2707449255
https://github.com/SillyTavern/SillyTavern/pull/5032#discussion_r2707455801
https://github.com/SillyTavern/SillyTavern/pull/5032#discussion_r2707458468

* Removed and altered: https://github.com/SillyTavern/SillyTavern/pull/5032#discussion_r2710152562 https://github.com/SillyTavern/SillyTavern/pull/5032#discussion_r2710125321 https://github.com/SillyTavern/SillyTavern/pull/5032#discussion_r2710129926 https://github.com/SillyTavern/SillyTavern/pull/5032#discussion_r2707430359

* Get rid of nested lists

---------

Co-authored-by: user <user@exmaple.com>
Co-authored-by: Cohee <18619528+Cohee1207@users.noreply.github.com>
This commit is contained in:
DeclineThyself
2026-01-22 22:24:38 +00:00
committed by GitHub
parent d6a20ba546
commit cc12ace48d
1 changed files with 52 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CONTRIBUTING.md
+52 -21
View File
@@ -12,32 +12,63 @@
2. Fork this repository under your account. 2. Fork this repository under your account.
3. Clone the fork onto your machine. 3. Clone the fork onto your machine.
4. Open the cloned repository in the code editor. 4. Open the cloned repository in the code editor.
5. Create a git branch (recommended). 5. Create a git branch (recommended), review the [git book](https://git-scm.com/book/en/v2/Getting-Started-About-Version-Control) if you haven't.
6. Make your changes and test them locally. 6. Make your changes and test them locally.
7. Commit the changes and push the branch to the remote repo. 7. Commit the changes and push the branch to the remote repo.
8. Go to GitHub, and open a pull request, targeting the upstream branch. 8. Go to GitHub, and open a pull request, targeting the appropriate upstream branch.
## Contribution guidelines ## Contribution guidelines
1. Our standards are pretty low, but make sure the code is not too ugly: ### Maintain code quality
- Run VS Code's autoformat when you're done.
- Check with ESLint by running `npm run lint`, then fix the errors. Our standards are pretty low, but make sure the code is not too ugly:
- Use common sense and follow existing naming conventions.
2. Create pull requests for the staging branch, 99% of contributions should go there. That way people could test your code before the next stable release. - Run VS Code's autoformat when you're done.
3. You can still send a pull request for release in the following scenarios: - Check with ESLint by running `npm run lint`, then fix the errors.
- Updating README. - Use common sense and follow existing naming conventions.
- Updating GitHub Actions.
- Hotfixing a critical bug. ### Use the correct target branch
4. Project maintainers will test and can change your code before merging. To keep our workflow smooth, please ensure the following:
- The "Allow edits from maintainers" option is checked. Create pull requests for the `staging` branch, 99% of contributions should go there. That way people could test your code before the next stable release.
- Avoid force-pushing your branch once the PR is out of draft state.
5. To make sure that your contribution remains testable and reviewable, try not to exceed a soft limit of **200 lines of code** (both additions and deletions) per pull request. If you have more to contribute, split it into multiple pull requests. We can also consider creating a separate feature branch for more substantial changes, but please discuss it with the maintainers first. You can still send a pull request for `release` in the following scenarios:
6. Write at least somewhat meaningful PR descriptions and commit messages. There's no "right" way to do it, but the following may help with outlining a general structure:
- What is the reason for a change? - Updating README.
- What did you do to achieve this? - Updating GitHub Actions.
- How would a reviewer test the change? - Hotfixing a critical bug.
7. English is the primary language of communication in this project. Please use only English when writing commit messages, PR descriptions, comments and other text. This does not apply to contributions to localization files.
8. Mind the license. Your contributions will be licensed under the GNU Affero General Public License. If you don't know what that implies, consult your lawyer. Project maintainers will test and can change your code before merging. To keep our workflow smooth, please ensure the following:
- The "Allow edits from maintainers" option is checked.
- Avoid force-pushing your branch once the PR is out of draft state.
### Make contributions small and testable
To make sure that your contribution remains testable and reviewable, try not to exceed a soft limit of **200 lines of code** (both additions and deletions) per pull request. If you have more to contribute, split it into multiple pull requests.
We can also consider creating a separate feature branch for more substantial changes, but please discuss it with the maintainers first. For example:
- Leave the main larger PR as a draft so it can be used to discuss the implementation.
- Split each group of functions or features into a ~200 line PR so it can be properly reviewed and merged to staging or a feature branch.
- If there are large codependent changes that cannot be split, start with the most utilized dependencies and stub dependent functions.
- Each will be reviewed and tested one by one, merging into the feature branch as they're ready.
- Do not create all branches in advance, as subsequent changes made in previous commits as a result of test/review may create a lot of merge conflicts.
### Provide clear descriptions of your changes
Write at least somewhat meaningful PR descriptions and commit messages. There's no "right" way to do it, but the following may help with outlining a general structure:
- What is the reason for a change?
- What did you do to achieve this?
- How would a reviewer test the change?
### We (likely) don't speak your language
English is the primary language of communication in this project. Please use only English when writing commit messages, PR descriptions, comments and other text. This does not apply to contributions to localization files.
### Legal stuff
Mind the license. Your contributions will be licensed under the GNU Affero General Public License. If you don't know what that implies, consult your lawyer.
## Use of AI coding assistance tools ("Vibe Coding") ## Use of AI coding assistance tools ("Vibe Coding")